My “reliably” issue was the fact that I could select ‘more’ and ‘bank’ in all versions (including 2.261), but selecting the right bank had a very narrow range without invoking the split screen. The dropdown in Play Mode in 2.266 does work for both more and bank. From my point-of-view, I would rather not have split screen implemented. We have incorporated this fix into our app and have been testing it internally.I apologize if I seem a bit anxious about your solution. Verified that in the scenario described above where window dimensions are updated later, we get correct dimension values in JS. Verified that after orientation dimensions are updated. Verified with a sample app that correct dimensions are available when app launches. This should not be an issue as it is to make sure dimensions in JS side are correct.
INVOKE IPAD PRO SPLIT SCREEN UPDATE
Previously initial orientation value was 0 which meant when app started in normal portrait orientation, first layout did not trigger a dimension update event. Which results in first change to trigger an event. Other change is that initial value for both window and screen fields is empty. One for window dimensions and one for screen dimensions update. This will cause two events to be sent to JS. One example is the case above where window dimensions take time to update, but screen dimensions are updated immediately. This has a side effect of sending dimension update twice in some cases. This ensures that whenever dimensions change, JS gets the updated values. When a change is detected, an event is sent to JS with updated dimensions. Now RN keeps track of previous window and screen dimension values. Global layout listener callback does get invoked a second time when resources object is finally updated with new dimensions, but since orientation no longer changes, no event is sent to JS.įixed this by separating dimensions update from orientation update. This causes dimensions update to be sent to JS with old window dimensions. And when orientation change is detected in global layout, resources object is not updated with new dimensions yet.
In cases when app is doing a lot of work on the main thread, like app startup, it takes more time to update the resources object. This is not the case for window dimensions as they are retrieved from resources object which gets updated asynchronously after orientation change. It is assumed, when orientation changes, new dimensions are available immediately. When a change is detected, orientation and dimension change events are sent to JS. Inside the callback current and previous orientations are compared. After rotation global layout listener callback gets invoked. Was able to reproduce this when device was rotated during app launch. This happened because in certain scenarios, after device orientation changed, dimensions update event from ReactRootView had incorrect dimensions. In certain cases when device was in portrait, window dimensions reported landscape dimensions and vice versa. There was a bug with RN.Dimensions returning incorrect window dimensions.
INVOKE IPAD PRO SPLIT SCREEN CODE
Also, I don't get why it use NotificationCenter stuffs or why they use the status bar orientation to get the orientation change of all the screen…Įdit: ok apparently NotificationCenter is just a EventEmmiter, nothing related to Notifications for end-user (I thought that it was a very tricky code ^^') I think we need to create a new observer for the event, but I'm not an iOS dev, and I don't understand all the code in this file. It send the correct value but it didn't trigger a change event on Dimensions when resizing the app window in a Split-View mode.Ĭurrently, two fonctions in Obj-C can trigger this event : didReceiveNewContentSizeMultiplier and interfaceOrientationDidChange. Don't use RCTScreenSize since it the interface orientation doesn't apply to itĬGRect screenSize = bounds] Static NSDictionary *RCTExportedDimensions(RCTBridge *bridge) Snack Expo is here : but it need to be tested on an iPad Device or Simulator. It can be easily tested on iPad by adding console.log(Dimensions.get('window')) anywhere in an existing app or in a fresh create-react-native-app.Īnd using Split View and Slide Over features of iOS on iPad. Console.log(Dimensions.get('screen')) // Reproducible Demo
0 kommentar(er)
